[MERGE][#299254] Fix RemoteTransport's translation of errors involving paths; it wasn't passing orig_path to _translate_error.
John Arbash Meinel
john at arbash-meinel.com
Thu Nov 20 15:24:29 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Vincent Ladeuil wrote:
> Vincent Ladeuil has voted approve.
> Status is now: Approved
> I'm not a big fan of error translation factorization because it makes it
> hard to refine diagnosis under some circumstances. But since this patch
> doesn't make that part worse, I think it should go in. And in that
> particular case, having a single point to translate the errors may be
> more appropriate than usual (since a serialization is involved anyway).
> I also find a bit strange (not to say it violates some abstraction) that
> 'orig_path' seems to pop out of nowhere but at least the comment
> explains that.
> In a followup patch, you may want to review the other calls to
> _translate_error to make them more consistent (_readv for example
> doesn't pass relpath as a parameter and the parameter name itself is a
> bit unclear since path and orig_path are used in different places).
Just as a follow up, why call it "orig_path" rather than "relpath" like
all of the transport functions call it.
Otherwise this seems fine to me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar