Bazaar 1.9 rc1-3 Windows installers

[Mark Hammond]

> As part of debugging it, I'm running the tbzr_tracer.exe. And I'm a bit
> surprised with what I see.
> 
> Specifically, I'm getting a lot of errors as it runs. It seems to be a
> problem with the "IsMemberOf" function:

IsMemberOf is the COM function used for icon overlays.

> Traceback (most recent call last):
>   File "win32com\server\dispatcher.pyo", line 171, in _InvokeEx_
>   File "win32com\server\dispatcher.pyo", line 79, in _InvokeEx_
>   File "win32com\server\dispatcher.pyo", line 129, in _HandleException_
>   File "win32com\server\dispatcher.pyo", line 77, in _InvokeEx_
>   File "win32com\server\policy.pyo", line 332, in _InvokeEx_
>   File "win32com\server\policy.pyo", line 593, in _invokeex_
>   File "iconoverlay.pyo", line 97, in IsMemberOf
>   File "iconoverlay.pyo", line 51, in get_status_for
>   File "tbzrlib\pipe\client.pyo", line 350, in request_file_status
>   File "tbzrlib\pipe\client.pyo", line 336, in make_remote_request
> <class 'tbzrlib.pipe.client.RemoteRequestFailed'>: (1003, 'Cannot
> complete this function.')

In this case, we shouldn't be dumping an exception - it means that the remote end of the pipe didn't return a result.  This usually means that the tbzrcache process itself had an exception.  (We haven't bothered with a way to move exception info to the client - in general it has no way of displaying it.

So you are probably looking for an exception in .bzr.log written by tbzrcache.exe

> It seems to get a traceback for *every* file in a directory. Also, the
> 'tbzr' process took a really long time to add an icon to my systray,
> even though things were obviously going on.
> 
> Also, when browsing the top-level of bzr.dev, it doesn't add an overlay
> to the subdirectories.

I expect you will never see an icon when a traceback was generated.

> 1) We definitely have a problem where we aren't installing
> TortoiseOverlays as part of the install. The workaround right now is to
> install it manually. You can get it from:
> http://tortoisesvn.tigris.org/svn/tortoisesvn/TortoiseOverlays/version-
> 1.0.4/bin/TortoiseOverlays-1.0.4.11886-win32.msi

That is strange!

> 2) There is something wrong with the IsMemberOf function

Or with the tbzrcache end of the process.

> 3) I do see this in .bzr.log:
> RuntimeError: Status of 'C:\Users\jameinel\dev\bzr\bzr.dev' would
> recurse to death
> 
> Mark has commented that this is fixed, but he must not have pushed the
> fix to Launchpad, as I should be using the latest version of tbzr. (I
> see a *lot* of these in the log.)

Can you please confirm that you have rev 125 here?  That is where I thought it was fixed, but I suspect there may be one other place it could hit.

> Is there any chance to have this set up to run out of a source dir? I'd
> really like to be able to hack on it, and test right away, like I do
> for
> the rest of bzr.

The tbzr wiki has some info on that.  Basically, just set PYTHONPATH to point at bzrlib and tbzrlib, then:
* register the shell extension by executing 'python tbzr\shellext\python\tbzr.py

* Start the tbzrcache process manually in a cmd-prompt.

* Start a new explorer process, or start notepad and hit file->open

And you should be good to go...

Cheers,

Mark