Bazaar 1.9 rc1-3 Windows installers

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

> Something does seem wrong, though, and it may be that it isn't actually
> getting installed. You could try installing manually and see if that
> fixes anything.
> 
> I'm also going to try some things here, and I'll see what happens.
> 
> John
> =:->


So after installing TortoiseOverlays manually, it does indeed start
showing overlays. So there is something wrong with the installer, that
it is not installing it automatically.

As part of debugging it, I'm running the tbzr_tracer.exe. And I'm a bit
surprised with what I see.

Specifically, I'm getting a lot of errors as it runs. It seems to be a
problem with the "IsMemberOf" function:

Traceback (most recent call last):
  File "win32com\server\dispatcher.pyo", line 171, in _InvokeEx_
  File "win32com\server\dispatcher.pyo", line 79, in _InvokeEx_
  File "win32com\server\dispatcher.pyo", line 129, in _HandleException_
  File "win32com\server\dispatcher.pyo", line 77, in _InvokeEx_
  File "win32com\server\policy.pyo", line 332, in _InvokeEx_
  File "win32com\server\policy.pyo", line 593, in _invokeex_
  File "iconoverlay.pyo", line 97, in IsMemberOf
  File "iconoverlay.pyo", line 51, in get_status_for
  File "tbzrlib\pipe\client.pyo", line 350, in request_file_status
  File "tbzrlib\pipe\client.pyo", line 336, in make_remote_request
<class 'tbzrlib.pipe.client.RemoteRequestFailed'>: (1003, 'Cannot
complete this function.')
in <iconoverlay.1TortoiseBZRUnknownOverlay object at
0x031F6AD0>._InvokeEx_-IsMemberOf(u'C:\\Users\\jameinel\\dev\\bzr\\1.7-dev',
16) [1,0,None]
5040:TransactNamedPipe result was 0 (success=True)
5040:remote response returned 4 bytes
ERROR: Remote response error: errcode=1003
Traceback (most recent call last):
  File "win32com\server\dispatcher.pyo", line 77, in _InvokeEx_
  File "win32com\server\policy.pyo", line 332, in _InvokeEx_
  File "win32com\server\policy.pyo", line 593, in _invokeex_
  File "iconoverlay.pyo", line 97, in IsMemberOf
  File "iconoverlay.pyo", line 51, in get_status_for
  File "tbzrlib\pipe\client.pyo", line 350, in request_file_status
  File "tbzrlib\pipe\client.pyo", line 336, in make_remote_request
RemoteRequestFailed: (1003, 'Cannot complete this function.')
pythoncom error: Unexpected exception in gateway method 'IsMemberOf'

Traceback (most recent call last):
  File "win32com\server\dispatcher.pyo", line 171, in _InvokeEx_
  File "win32com\server\dispatcher.pyo", line 79, in _InvokeEx_
  File "win32com\server\dispatcher.pyo", line 129, in _HandleException_
  File "win32com\server\dispatcher.pyo", line 77, in _InvokeEx_
  File "win32com\server\policy.pyo", line 332, in _InvokeEx_
  File "win32com\server\policy.pyo", line 593, in _invokeex_
  File "iconoverlay.pyo", line 97, in IsMemberOf
  File "iconoverlay.pyo", line 51, in get_status_for
  File "tbzrlib\pipe\client.pyo", line 350, in request_file_status
  File "tbzrlib\pipe\client.pyo", line 336, in make_remote_request
<class 'tbzrlib.pipe.client.RemoteRequestFailed'>: (1003, 'Cannot
complete this function.')
pythoncom error: Unexpected gateway error


It seems to get a traceback for *every* file in a directory. Also, the
'tbzr' process took a really long time to add an icon to my systray,
even though things were obviously going on.

Also, when browsing the top-level of bzr.dev, it doesn't add an overlay
to the subdirectories.

Now if I go *into* a subdir, then it adds icons to all of the sub-sub
directories.

For example, if I'm in bzr.dev then bzrlib, contrib, doc, tools do not
have Icons (though bzr.ico, bzr, etc *do*).

And then if I go to "doc" then I see icons for developers, en, es, etc.

Though this seems to be specific to bzr.dev, because in my "alt_work"
directory, all of the directories get overlays properly.

So...

1) We definitely have a problem where we aren't installing
TortoiseOverlays as part of the install. The workaround right now is to
install it manually. You can get it from:
http://tortoisesvn.tigris.org/svn/tortoisesvn/TortoiseOverlays/version-1.0.4/bin/TortoiseOverlays-1.0.4.11886-win32.msi

username: guest
password: <blank>

2) There is something wrong with the IsMemberOf function

3) I do see this in .bzr.log:
RuntimeError: Status of 'C:\Users\jameinel\dev\bzr\bzr.dev' would
recurse to death

Mark has commented that this is fixed, but he must not have pushed the
fix to Launchpad, as I should be using the latest version of tbzr. (I
see a *lot* of these in the log.)

So in general, I think things are rather "alpha". It sort of works, but
it could use a bit more work.


Mark-

Is there any chance to have this set up to run out of a source dir? I'd
really like to be able to hack on it, and test right away, like I do for
the rest of bzr.


John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkTD4QACgkQJdeBCYSNAAMVNACfVEHfyJA1xK4Lps6V9WTBncy+
DdsAnRYhbLxW6rBuBxSMyjbtVQTvWfa9
=/ZCi
-----END PGP SIGNATURE-----