[MERGE] Shelf 1 / 5: TreeTransform serialization

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> I don't really understand this critique.  I'm not asserting anything
>> about a specific on-disk format.  If a pack2 format should be invented,
>> I would hope that this code would work, unchanged, with it.
> 
> ...
> 
>> I think that it would make a great deal of sense for ShelfCreator's
>> tests to ensure that a particular on-disk format used.  In that scope,
>> we're actually talking about shelves, and we do actually care about the
>> on-disk format.  I don't think this is the right place for this kind of
>> test.

> Well in fairness you are calling it "serialize", which to me means "turn
> into a byte sequences" which should be something stable across releases.
> I can understand where you would consider ShelfCreator to be the right
> place for testing it, but this *does* create a file on disk (.shelf2/01,
> IIRC).

No, it does not create a file on disk.  It yields a sequence of records,
with a format that depends on the serializer that is passed in.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj+EO0ACgkQ0F+nu1YWqI3DtgCfQOje6clrALlkIIP+Vk8Q7icn
v5sAnjQWIH73TrBiF/21mm/06kdyvyrI
=Mn+F
-----END PGP SIGNATURE-----