[MERGE] Shelf 1 / 5: TreeTransform serialization

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> So deserialize can be exercised by passing in a manually-constructed
>>> list of records.  serialize can be exercised with an implementation of
>>> Pack that simply creates a list of records.
>>> Does that seem right to you?
> 
>> That seems ok. I think Robert's idea is fine as well, though I'm
>> thinking we should probably still be asserting the pack format you want
>> to be using.
> 
> I don't really understand this critique.  I'm not asserting anything
> about a specific on-disk format.  If a pack2 format should be invented,
> I would hope that this code would work, unchanged, with it.

...

> I think that it would make a great deal of sense for ShelfCreator's
> tests to ensure that a particular on-disk format used.  In that scope,
> we're actually talking about shelves, and we do actually care about the
> on-disk format.  I don't think this is the right place for this kind of
> test.
> 
> Aaron
> 

Well in fairness you are calling it "serialize", which to me means "turn
into a byte sequences" which should be something stable across releases.
I can understand where you would consider ShelfCreator to be the right
place for testing it, but this *does* create a file on disk (.shelf2/01,
IIRC).

I realize you change the code around in a following patch, but as I was
reviewing them in order, I didn't have a chance to know that when I was
reviewing this.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj9/VwACgkQJdeBCYSNAANQMACgv0PGzVBfUH186KqkSP967rQM
X1QAn0fpHa8tqp1gTbaA2CxzwgEJyZQW
=hLkf
-----END PGP SIGNATURE-----