[MERGE] Shelf 1 / 5: TreeTransform serialization

Aaron Bentley aaron at aaronbentley.com
Sun Oct 26 14:11:44 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Yet I agree that some direct tests of serialize and deserialize make sense.
> 
>> So deserialize can be exercised by passing in a manually-constructed
>> list of records.  serialize can be exercised with an implementation of
>> Pack that simply creates a list of records.
> 
>> Does that seem right to you?

> That seems ok. I think Robert's idea is fine as well, though I'm
> thinking we should probably still be asserting the pack format you want
> to be using. It just depends how strong you want to guarantee that
> different versions of bzr can re-use the shelf contents.

Here's a new version that tests serialization and deserialization
directly.  Since it doesn't use a particular on-disk format, I'm not
testing an on-disk format.

I've also changed the test so that unicode symlink targets are created.
 (Strangely, they always come back in utf-8)

If you still feel that it makes sense to test a particular on-disk
format in this thread, please let me know why.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkEepwACgkQ0F+nu1YWqI0NYwCfQkQwLl6pe5Fi1jw8+FURKo8y
o0IAnijZ8T7+bFQ9D5lET1yFd7WipFOc
=922W
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shelf-serialization.patch
Type: text/x-diff
Size: 34845 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081026/cd48cebf/attachment-0001.bin 


More information about the bazaar mailing list