[MERGE] dont stacktrace on bad plugin versions

[Marius Kruger]

2008/10/15 John Arbash Meinel <john at arbash-meinel.com>

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Marius Kruger wrote:
> > Hi,
> ...
> > It turns out that one of my plugins (xmloutput) has a non-standard
> > version number:
> > version_info = (0, 9, 0, 'dev')
> > which looks fine if you dont know better.
> >
> > I could not find any place in the documentation which specifies what
> > this version
> > number should contain, so I added a little something.
> >
> > I also thought that it'll be much nicer of us to rather format whatever
> > is in there
> > in stead of throwing our toys out of the cot.
>
> BB:tweak


thanks for the quick review!


> I would recommend using "bzrlib._format_version_tuple"


done,
but it turns out that _format_version_tuple does not like dev and final
versions with a zero sub-release,
so I had to change the tests a little.


> and *the* falling
> back to ''.join(map(str...))
>

done

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081016/e9ada60f/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr.bad_plugin_versions2.patch
Type: text/x-patch
Size: 7356 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081016/e9ada60f/attachment.bin