[MERGE] dont stacktrace on bad plugin versions

John Arbash Meinel john at arbash-meinel.com
Wed Oct 15 21:34:02 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger wrote:
> Hi,
> 
> For background I did:
> $ bzr branches bzr+https://me@someserver/bzr/myrepo/
> poc/EBRClientPrototype.dev
> 
> which worked fine. then
> $ bzr branches bzr+https://me@someserver/bzr/
> 
> threw a stack trace, but when it tries to make a message with all the
> plugin versions
> for the user to be able to report a bug, it trows another exception :(
> 
> It turns out that one of my plugins (xmloutput) has a non-standard
> version number:
> version_info = (0, 9, 0, 'dev')
> which looks fine if you dont know better.
> 
> I could not find any place in the documentation which specifies what
> this version
> number should contain, so I added a little something.
> 
> I also thought that it'll be much nicer of us to rather format whatever
> is in there
> in stead of throwing our toys out of the cot.
> 
> regards
> marius
> 

BB:tweak

I would recommend using "bzrlib._format_version_tuple" and *the* falling
back to ''.join(map(str...))

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj2U7oACgkQJdeBCYSNAANMlQCePPxH35PVaPwBxLLHqM6BrpHZ
Ps8AnjlG6iJ86sD7tVVakxjpE6qherdL
=jwCj
-----END PGP SIGNATURE-----



More information about the bazaar mailing list