<div dir="ltr">2008/10/15 John Arbash Meinel <span dir="ltr"><<a href="mailto:john@arbash-meinel.com">john@arbash-meinel.com</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> -----BEGIN PGP SIGNED MESSAGE-----<br> Hash: SHA1<br> <div><div></div><div class="Wj3C7c"><br> Marius Kruger wrote:<br> > Hi,<br> ...<br> > It turns out that one of my plugins (xmloutput) has a non-standard<br> > version number:<br> > version_info = (0, 9, 0, 'dev')<br> > which looks fine if you dont know better.<br> ><br> > I could not find any place in the documentation which specifies what<br> > this version<br> > number should contain, so I added a little something.<br> ><br> > I also thought that it'll be much nicer of us to rather format whatever<br> > is in there<br> > in stead of throwing our toys out of the cot.<br> <br> </div></div>BB:tweak</blockquote><div> </div><div>thanks for the quick review! <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <br> I would recommend using "bzrlib._format_version_tuple" </blockquote><div><br>done, <br>but it turns out that _format_version_tuple does not like dev and final versions with a zero sub-release, <br>so I had to change the tests a little.<br>  <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">and *the* falling<br> back to ''.join(map(str...))<br> </blockquote><div><br>done<br><br>regards<br>marius<br></div></div><br> </div>