[MERGE] bzr+http// with plugins and logs (was [HELP!] serverside hooks behind bzr+http://)

[Marius Kruger]

2008/9/14 Andrew Bennetts <andrew at canonical.com>

> Marius Kruger wrote:
>
> > do you think we should get `wsgi.make_app()` to do this automatically?
> >
> > then we can add additional parameters:
> > smart_server_app = wsgi.make_app(
> >     root='/var/lib/gforge/bzrroot',
> >     prefix='/bzr/',
> >     path_var='REQUEST_URI',
> >     readonly=False,
> >     load_plugins=True,
> >     logfile='/var/log/bazaar.fcgi.log',
> > )
>
> I think that's a good idea.
>
> > note I also want to get the logging working (properly set, or properly
> > disabled), because I get a lot of `No handlers could be found for logger
> > "bzr"` in my apache log.
> >
> > I'll probably hack a patch together for this soon, if it sounds ok to
> you.
>
> It does, thank you!
> -Andrew.
>
>
Here is a quick patch which adds `load_plugins=True, enable_logging=True`
parameters
to wsgi.make_app ()
Which allows  bzr+http:// users to easily get plugins loading and logs
written!

* I didn't give the option to name the log file, because I didn't have the
time and energy now.
   So if people think its a must-have, I can do that a little later.
* I could not find a good place to add tests, and saw that tests for this
might be quite tricky.
* I would add news if people are happy with what I did so far.


-- 
regards
Marius

<><
http://amanica.blogspot.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20080915/c535d9ee/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr_http_with_plugins_and_logs.patch
Type: text/x-diff
Size: 4520 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080915/c535d9ee/attachment.bin