<div dir="ltr"> <div class="gmail_quote">2008/9/14 Andrew Bennetts <<a href="mailto:andrew@canonical.com">andrew@canonical.com</a>> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">Marius Kruger wrote: </div> <div class="Ih2E3d"> > do you think we should get `wsgi.make_app()` to do this automatically? > > then we can add additional parameters: > smart_server_app = wsgi.make_app( >     root='/var/lib/gforge/bzrroot', >     prefix='/bzr/', >     path_var='REQUEST_URI', >     readonly=False, >     load_plugins=True, >     logfile='/var/log/bazaar.fcgi.log', > ) </div>I think that's a good idea. <div class="Ih2E3d"> > note I also want to get the logging working (properly set, or properly > disabled), because I get a lot of `No handlers could be found for logger > "bzr"` in my apache log. > > I'll probably hack a patch together for this soon, if it sounds ok to you. </div>It does, thank you! -Andrew. </blockquote></div> Here is a quick patch which adds `load_plugins=True, enable_logging=True` parameters to wsgi.make_app () Which allows  bzr+http:// users to easily get plugins loading and logs written! * I didn't give the option to name the log file, because I didn't have the time and energy now.    So if people think its a must-have, I can do that a little later. * I could not find a good place to add tests, and saw that tests for this might be quite tricky. * I would add news if people are happy with what I did so far. -- regards Marius <>< <a href="http://amanica.blogspot.com/">http://amanica.blogspot.com/</a> </div>