[RFC] detecting "file not found" and "directory not found" exceptions on Windows

[Andrew Bennetts]

John Arbash Meinel wrote:
[...]
> So the problem with your patch is that you only check "errno == EINVAL"
> without checking that "winerror == ERROR_DIRECTORY".
> 
> The other difficulty is that we should really get a second reviewer's
> approval before merging it. And with Martin gone, and Andrew leaving...
> 
> Anyway, I'll put something together based on your patch and submit it
> with MERGE. I *do* think it should go into 1.6, as it is a serious
> regression in functionality.

I can do a review:

bb:tweak 

:)

In addition to John's comments:

> > +            # Py 2.4 and earlier will set errno to EINVAL to 
> > +            # ERROR_DIRECTORY (267).  Later versions set it to

I think you mean “to EINVAL or ERROR_DIRECTORY” (i.e. replace a “to” with an
“or”).

I agree it would be good to have this abstracted into just one place in osutils
eventually.

-Andrew.