[merge] review of overall protocol3 diff

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



...

|> +    def bytes_part_received(self, bytes):
|> +        self._body_started = True
|> +        self._bytes_parts.append(bytes)
|>
|> should check here we already have the args?
|
| No, it's valid for a response to receive multiple bytes parts (if it is a
| streaming body).  See
|
<http://doc.bazaar-vcs.org/bzr.dev/developers/network-protocol.html#conventional-requests-and-responses>.
|

I think he's saying something like:

assert self._args is not None

Just to say that we know args has to come before "bytes_parts" so check that we
have already gotten them. Even if you receive multiple bytes_parts, don't they
all have to come after the Request args?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgtty4ACgkQJdeBCYSNAAPDwwCgjOkLkUnivjqZhOYzVb2fAhuD
NNsAoMerP6mws/dSvMPCzzHTV/VfFa89
=5DQh
-----END PGP SIGNATURE-----