[merge] review of overall protocol3 diff

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



...

|
| To bzrlib?  Ok, I'll _underscore them.
|
|> @@ -616,6 +705,8 @@
|>              return 1
|>          elif resp == ('ok', '2'):
|>              return 2
|> +        elif resp == ('ok', '3'):
|> +            return 3
|>          else:
|>              raise errors.SmartProtocolError("bad response %r" % (resp,))
|>
|> This also needs to be reverted I think.
|
| Done.
|
| -Andrew.

You know, if you did:

if len(resp) == 2 and resp[:1] == 'ok':
~  return int(resp[2])

We might be a little more future proof. Just a thought, I realize we aren't
going this route anymore.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgtsEkACgkQJdeBCYSNAANMhwCfTplBuUmnMilxCOvOneTlgE1r
U/oAoKmm7rSB4tyLR3a/SsBfqYk5NRSg
=t9T6
-----END PGP SIGNATURE-----