[MERGE] Deprecate VersionedFile.iter_parents
Robert Collins
robertc at robertcollins.net
Wed Apr 9 22:28:15 BST 2008
On Wed, 2008-04-09 at 10:39 +0300, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> | iter_parents can go now. Yay, watch the api shrink.
> |
> | -Rob
> |
> |
> |
>
> BB:tweak
>
> You seem to remove the implementations in favor of the generic implementation,
> which is fine. But you don't actually add the deprecation symbol to the generic
> function.
I do - its the last hunk of the patch.
> Also, you remove the test cases for it, while we generally have a policy of
> leaving the test cases around with a "applyDeprecated".
>
> Then again, you might be testing the VF version somewhere, and just removing say
> the Knit specific one. We just need to make sure there is a test somewhere so we
> don't break a deprecated function until it is removed.
Thats exactly what I do - I keep the generic tests (the ones changed to
use applyDeprecated).
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080410/e0f5fb46/attachment.pgp
More information about the bazaar
mailing list