[MERGE] Deprecate VersionedFile.iter_parents

John Arbash Meinel john at arbash-meinel.com
Wed Apr 9 08:39:42 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
| iter_parents can go now. Yay, watch the api shrink.
|
| -Rob
|
|
|

BB:tweak

You seem to remove the implementations in favor of the generic implementation,
which is fine. But you don't actually add the deprecation symbol to the generic
function.

Also, you remove the test cases for it, while we generally have a policy of
leaving the test cases around with a "applyDeprecated".

Then again, you might be testing the VF version somewhere, and just removing say
the Knit specific one. We just need to make sure there is a test somewhere so we
don't break a deprecated function until it is removed.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/HK+JdeBCYSNAAMRAnaEAJ4paZa6JkZ04ysEIkZ41Sm1CKWOwQCcDl1g
plQiPyRmEp9ToMI5ditb5K4=
=RVAp
-----END PGP SIGNATURE-----




More information about the bazaar mailing list