[MERGE] Deprecate VersionedFile.get_graph_with_ghosts.
robertc at robertcollins.net
Fri Mar 28 01:41:13 GMT 2008
On Fri, 2008-03-28 at 11:32 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:
> > *boom*
> The changes seem ok to me but you need some more of them in order for
> the tests to pass. Firstly a tweak: be sure to import deprecated_method
> and one_four in knit.py. Secondly (and I reason I voted resubmit rather
> than tweak), the removal of get_graph from _KnitIndex is breaking
> has_ghost ...
Thats because you're reviewed an already superseded patch. Perhaps BB
should send mail when it supersedes automatically?
> AttributeError: '_KnitIndex' object has no attribute 'get_graph'
> You might also want to note that get_graph() is being deprecated though
> it's only removed on the index here, not deprecated, so I gather the
> deprecation (on VersionedFile) is in another (possibly already
> submitted) patch.
_KnitIndex is not public in any manner, theres no need to document this.
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080328/1c820898/attachment.pgp
More information about the bazaar