[MERGE] Deprecate VersionedFile.get_graph_with_ghosts.

Robert Collins robertc at robertcollins.net
Fri Mar 28 01:50:56 GMT 2008


On Fri, 2008-03-28 at 12:41 +1100, Robert Collins wrote:
> On Fri, 2008-03-28 at 11:32 +1000, Ian Clatworthy wrote:
> > Robert Collins wrote:
> > > *boom*
> > > 
> > 
> > bb:resubmit
> > 
> > The changes seem ok to me but you need some more of them in order for
> > the tests to pass. Firstly a tweak: be sure to import deprecated_method
> > and one_four in knit.py. Secondly (and I reason I voted resubmit rather
> > than tweak), the removal of get_graph from _KnitIndex is breaking
> > has_ghost ...
> 
> Thats because you're reviewed an already superseded patch. Perhaps BB
> should send mail when it supersedes automatically?

or I could be confused; it was the other patch that I superseded.
Anyhow, the combination of the two is totally fine test suite wise :>.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080328/4d09c27b/attachment.pgp 


More information about the bazaar mailing list