[MERGE][#182849] Don't traceback on host name errors when connecting to bzr://...

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> When connecting to a plain TCP smart server (bzr://foo/...) bzrlib.smart.medium
> was using socket_object.connect_ex without catching exceptions, however
> connect_ex does raise errors in some situations, e.g. when a host name could not
> be resolved.  This caused <https://bugs.launchpad.net/bzr/+bug/182849>.
> 
> This patch uses connect rather than connect_ex, and if it fails, it catches the
> exception and extracts the appropriate error string from the exception.  This
> should properly catch all errors from connecting the socket, and make sure they
> are reported correctly.
> 
> -Andrew.
> 
> 

BB:approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHkTEcJdeBCYSNAAMRAsqMAJ0RZLnE0ApgbKwhSBptoQgyVCQlXQCfbx/o
a00J3su758uHRlFChEgFqzY=
=oXfD
-----END PGP SIGNATURE-----