[MERGE][#182849] Don't traceback on host name errors when connecting to bzr://...

[Robert Collins]

bb:tweak

Commit it as is, but if its possible to test this... please do.

-Rob
On Tue, 2008-01-15 at 15:03 +1100, Andrew Bennetts wrote:
> When connecting to a plain TCP smart server (bzr://foo/...) bzrlib.smart.medium
> was using socket_object.connect_ex without catching exceptions, however
> connect_ex does raise errors in some situations, e.g. when a host name could not
> be resolved.  This caused <https://bugs.launchpad.net/bzr/+bug/182849>.
> 
> This patch uses connect rather than connect_ex, and if it fails, it catches the
> exception and extracts the appropriate error string from the exception.  This
> should properly catch all errors from connecting the socket, and make sure they
> are reported correctly.
> 
> -Andrew.
> 
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080115/3c825216/attachment.pgp