[MERGE] [Bug #148908] Return an error if the revisionspec contains merge revisions, but the log formatter doesn't support them.

Aaron Bentley aaron.bentley at utoronto.ca
Mon Nov 12 16:43:59 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Semi-approved
> Comment:
> I would sort of prefer it if we could log them in the single point case.
> (bzr log --short -r 1.2.2)
> 
> However, this error is better than getting an ugly traceback.
> 
> Oh, and I would generally prefer to use:
> 
> if (rev_id in dict) rather than (dict.has_key(rev_id))

bb:approve

True, but this is still a case of look-before-you-leap.  We could avoid
any performance hit in the general case by handling the exception in
_filter_revision_range instead of trying to avoid that exception.

Not that it matters in this case.  But avoiding look-before-you-leap is
a good habit to get into.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOILP0F+nu1YWqI0RAuT2AJ9Xm0/N1CIebCHB0yqLAMinjpTuQACfSqlE
MJSC+kR76RIEAU/dbJai3Qk=
=ebb9
-----END PGP SIGNATURE-----



More information about the bazaar mailing list