[MERGE] [Bug #148908] Return an error if the revisionspec contains merge revisions, but the log formatter doesn't support them.

Kent Gibson warthog618 at gmail.com
Mon Nov 12 23:02:24 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Semi-approved
> Comment:
> I would sort of prefer it if we could log them in the single point
> case. (bzr log --short -r 1.2.2)
As would I, but that would ignore the fact that the ShortLogFormatter
specifies that it doesn't support merge revisions.  I guess we need
another capability if the formatter can handle a single merge revision?
>
> However, this error is better than getting an ugly traceback.
>
> Oh, and I would generally prefer to use:
>
> if (rev_id in dict) rather than (dict.has_key(rev_id))
>
> Lots of things support the "x in y" syntax, only dicts really have
> ".has_key()". That way if we need to change something to a set, or
> something else, we don't have to worry about it.
>
True enough.  I must be getting rusty.  Updated patch attached.

Thanks,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHONuAgoxTFTi1P8QRAveMAKCVcS3DNTj2wSKAyaete6AZyCv/awCgyLdZ
IAWdghRBwCyqIVyCrMDmM/8=
=Y0Jf
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-ipuG24.patch
Type: text/x-patch
Size: 5190 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071113/f344ccfd/attachment.bin 


More information about the bazaar mailing list