[MERGE] (robertc) Remote object tweaks from the packs branch. (Robert Collins)

Martin Pool mbp at canonical.com
Tue Oct 2 06:09:40 BST 2007


On  2 Oct 2007, Robert Collins <robertc at robertcollins.net> wrote:
> On Tue, 2007-09-25 at 04:11 -0400, Vincent Ladeuil wrote:
> > Vincent Ladeuil has voted resubmit.
> > Status is now: Resubmit
> > Comment:
> > Wow, given that has_same_location is used by RepoFetcher.__init__ I'm 
> > surprised you didn't break any test...
> > 
> > repository.Repository do not have a 'base' attribute so I don't think 
> > you can assume RemoteRepository  will always be compared to another 
> > RemoteRepository.
> 
> So, I can add base to Repository; I think has_same_location is either
> misnamed, or broken, to be checking class.

I raised that before and (Andrew?) agreed it was broken and the class
check should be removed.  +1 if you want to go ahead and do that.

-- 
Martin Pool



More information about the bazaar mailing list