[MERGE] (robertc) Remote object tweaks from the packs branch. (Robert Collins)

Robert Collins robertc at robertcollins.net
Tue Oct 2 06:03:29 BST 2007


On Tue, 2007-09-25 at 04:11 -0400, Vincent Ladeuil wrote:
> Vincent Ladeuil has voted resubmit.
> Status is now: Resubmit
> Comment:
> Wow, given that has_same_location is used by RepoFetcher.__init__ I'm 
> surprised you didn't break any test...
> 
> repository.Repository do not have a 'base' attribute so I don't think 
> you can assume RemoteRepository  will always be compared to another 
> RemoteRepository.

So, I can add base to Repository; I think has_same_location is either
misnamed, or broken, to be checking class.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071002/7aae20b9/attachment.pgp 


More information about the bazaar mailing list