[MERGE] (robertc) Remote object tweaks from the packs branch. (Robert Collins)

Robert Collins robertc at robertcollins.net
Wed Oct 3 04:37:16 BST 2007


On Tue, 2007-10-02 at 15:09 +1000, Martin Pool wrote:
> On  2 Oct 2007, Robert Collins <robertc at robertcollins.net> wrote:
> > On Tue, 2007-09-25 at 04:11 -0400, Vincent Ladeuil wrote:
> > > Vincent Ladeuil has voted resubmit.
> > > Status is now: Resubmit
> > > Comment:
> > > Wow, given that has_same_location is used by RepoFetcher.__init__ I'm 
> > > surprised you didn't break any test...
> > > 
> > > repository.Repository do not have a 'base' attribute so I don't think 
> > > you can assume RemoteRepository  will always be compared to another 
> > > RemoteRepository.
> > 
> > So, I can add base to Repository; I think has_same_location is either
> > misnamed, or broken, to be checking class.
> 
> I raised that before and (Andrew?) agreed it was broken and the class
> check should be removed.  +1 if you want to go ahead and do that.

I've reverted the change from my branch; the change is not as simple as
adding a .base to Repository, because of the way this is used in fetch
during upgrade operations.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071003/be23f0e0/attachment.pgp 


More information about the bazaar mailing list