[MERGE] Send actually *sends* the merge directive

Aaron Bentley aaron.bentley at utoronto.ca
Tue Aug 21 18:33:32 BST 2007

Hash: SHA1

Goffredo Baroncelli wrote:
> On Monday 20 August 2007, John Arbash Meinel wrote:
>> John Arbash Meinel has voted tweak.
> [...]
> I think that is not a bazaar job to call an email client. There are too many 
> variabiles which are impossible to handle well in python.

Obviously, I disagree, but here's why:

I think that having a great "send" command that works out of the box is
achievable with Python.  I think it will make people like Bazaar a lot.
 I personally find it very convenient.

> I think that we have to add the option to call a script.
> For example if the client name in the option contains a slash, then bazaar 
> treats it as a script, and call it.

Config options are cheap-- there's no reason to play games with slashes
and things.  Furthermore, the "mail_client" option can be set in a
branch's bazaar.conf file, and executing commands based on an untrusted
remote url would be a major security vulnerability.

We could certainly support this by adding "script" as an optional mail
client, and then providing a "mail_client_script_path" config value
which would have to be trusted.

But I don't think we really want that either.  Sending mail is not a
particularly obscure activity.  We shouldn't require a significant
portion of our users to create/configure scripts at all.  That's
duplicate effort, and not even particularly fun.

> For example I made a script (which use dcop) which waits until a kmail windows 
> composer get the focus, then attaches the file. So I am able to attach 
> automatically a file to a "reply to" email (which are the 70% of the case 
> where I woul use the send command).

We already have an extensive MAPI client.  Nothing wrong with adding a
DCOP one, I think.  It would be better to solve all Kmail users' needs
rather than just yours, don't you think?


P.S. please trim your replies to only include the part you're responding to.
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the bazaar mailing list