[MERGE] Send actually *sends* the merge directive

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Conditionally approved
> Comment:
> This currently fails to send an email to a Unicode user. At least my test
> for:
> bzr send --mail-to "Jöhn john at arbash-meinel.com" ../jam-integration

I think this is a flaw in bzrlib.email_message, but I agree we ought to
fix it.

> You should really have some doc strings for the different functions.

Done.

> It might be a bit more legible as:
> 
> return (u"%s\n\n"
>         u"To: %s\n"
>         u"Subject: %s\n\n"
>         u"%s") % (prompt, to, subject,
>                   attachment.decode('utf-8', 'replace'))
> 
> But not everyone would prefer that form. So I'm not very sticky on it.

Done.

> On Mac OS X, it would be nice to be able to use Thunderbird, but none of
> the commands are in my path. I would be okay with explicitly setting the
> path to the "thunderbird", but I didn't see any way to do that.

Well, we can go down this rabbit hole a bit more.  I'll add
"/Applications/Mozilla/Thunderbird.app/Contents/MacOS/thunderbird-bin"
to the list of paths.

However, if I already have
> Thunderbird running, it gives me a pop-up saying that you can only have
> one instance at a time.
> 
> I don't know why this is still a problem, as I'm using Thunderbird
> 2.0.0.6, but it certainly isn't working.

Bizarre.  Certainly works fine on Ubuntu and Debian.

> Now, on Mac, I know that I can do "open mailto:john at arbash-meinel.com"
> and it will start a new compose window from my existing Thunderbird
> process.

Does it work to pass that commandline to Thunderbird directly?

> I haven't found any way to pass it anything other than the email
> address (everything else I try just gives me "no such file"). I did find
> that I can do:
>   open 'mailto:John%20Meinel%20%3cjohn at arbash-meinel.com%3e'

It might work with the same scheme as Evolution.  (Certainly, T-bird
also supports that, although 1.5 can't send an attachment that way.)
Try changing the Evolution command list to 'open', and setting your
client to "evolution".

> And sure enough, it composes to 2 people. But I wasn't able to create a
> subject or an attachment. ('subject=foo' just resulted in sending to
> someone
> named 'subject=foo')

That syntax is:

open mailto:aaron.bentley at utoronto.ca?subject=Hi&attach=file:///foo-bar

> Anyway, just because you don't work on Mac isn't a reason to block. Though
> it would be nice if we could figure out how 'mailto:' is doing the right
> thing. It might be that Mac uses something similar to MAPI.

I'll be interested to see what you find out.

> I didn't see any code in any of the commands to handle Unicode email
> addresses.

Fair enough.  I'll see what there is, though I have no idea how well
this is specified.

>  So Lukáš Lalinský will be a poor address. (I still haven't
> figured out how to type š on either Mac or Linux. I can't find that u
> combining character.)

Yeah, me neither.

> I think we've already solved the encoding issues when a user *writes* a
> unicode message in their editor. Though we should really be testing that
> the rest of the email sending code is handling it properly. (obviously it
> is failing somewhere for "Jöhn john at arbash-meinel.com").
> 
> 
> In some ways, I would be okay with merging it, even though it doesn't
> support Unicode. But if we do, then we need to open some bugs on it.

Okay, let's get it in.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGyj8T0F+nu1YWqI0RAqZtAJ45tqo/4mERyda3cQ+r2FJwIFfh0gCfTELF
3s68WgdbUG7wKzdo0WHFj/U=
=UFKn
-----END PGP SIGNATURE-----