[bug 93853][merge] Better message about inability to place tags in empty branch

John Arbash Meinel john at arbash-meinel.com
Tue Jul 31 21:06:58 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> James Westby wrote:
>> On (30/07/07 15:59), John Arbash Meinel wrote:
>>> I think we would want to do:
>>>
>>> revision_id = ensure_null(revision_id)
>>> if revision_id != _mod_revision.NULL_REVISION:
>>>     raise errors.***
>> Should that be an equality test?
> 
> It should be an equality test, rather than an identity test (because the
> string 'null:' can come from many sources), but it looks like the sense
> is inverted.  Should probably be "if revision_id ==
> _mod_revision.NULL_REVISION".
> 
> Aaron

yeah, I'm sure actually testing it would have caught that problem.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGr5ZiJdeBCYSNAAMRAt/7AJ9qTTUC1aQ3DYEdq7KhizNzX/XLbgCghxvD
KfLBYRQhoZifYuSgC6gnTEo=
=yibZ
-----END PGP SIGNATURE-----



More information about the bazaar mailing list