[bug 93853][merge] Better message about inability to place tags in empty branch

Aaron Bentley aaron.bentley at utoronto.ca
Tue Jul 31 20:56:27 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Westby wrote:
> On (30/07/07 15:59), John Arbash Meinel wrote:
>> I think we would want to do:
>>
>> revision_id = ensure_null(revision_id)
>> if revision_id != _mod_revision.NULL_REVISION:
>>     raise errors.***
> 
> Should that be an equality test?

It should be an equality test, rather than an identity test (because the
string 'null:' can come from many sources), but it looks like the sense
is inverted.  Should probably be "if revision_id ==
_mod_revision.NULL_REVISION".

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGr5Pr0F+nu1YWqI0RApFvAJ97wVvAr7oNn9Z0FEnjxF9401OtuQCfXpZL
kKXKoPpGsvRxJG6ID9oOy4c=
=4twV
-----END PGP SIGNATURE-----



More information about the bazaar mailing list