[Merge] workingtree.walkdirs to support walking an empty directory

[Martin Pool]

On 5/2/07, Marius Kruger <amanic at gmail.com> wrote:
> Hi all,
>
> While testing the 'bzr rm should delete the working file' patch
> Martin caught the case where we want to delete an empty directory,
> which failed because workingtree.walkdirs did not like it if we specify
> a prefix which represents an empty directory. I changed that patch
> to check if the directory is empty before calling walkdirs.
>
> I do consider this a bug in walkdirs, so here is a proper fix
> complete with tests. This is aimed at v0.17+ since there
> isn't many users of walkdirs, but could be useful for
> future users of it.

Hi Marius,

I was just checking up on this patch which is still in the review
queue here: http://bundlebuggy.aaronbentley.com/request/%3C418c22640705012222h5a72f900j4d0d7ae2c655a186@mail.gmail.com%3E

It's marked as unmerged, but it does look like deleting an empty
directory does now work.  Maybe I'm missing some subtlety of the error
this handles.  Do you know if this still wants to be merged?


-- 
Martin