[Merge] workingtree.walkdirs to support walking an empty directory

Marius Kruger amanic at gmail.com
Mon Jul 23 14:58:51 BST 2007


It just fixes a little bug in workingtree.walkdirs which I sidestepped when
deleting empty directories.
I am still intending to submit a version addressing the comments on the
But I just want to get some more important bugs fixed first,
so I'm fine with this patch being vetoed for now.


On 7/12/07, Martin Pool <mbp at sourcefrog.net> wrote:
> On 5/2/07, Marius Kruger <amanic at gmail.com> wrote:
> > Hi all,
> >
> > While testing the 'bzr rm should delete the working file' patch
> > Martin caught the case where we want to delete an empty directory,
> > which failed because workingtree.walkdirs did not like it if we specify
> > a prefix which represents an empty directory. I changed that patch
> > to check if the directory is empty before calling walkdirs.
> >
> > I do consider this a bug in walkdirs, so here is a proper fix
> > complete with tests. This is aimed at v0.17+ since there
> > isn't many users of walkdirs, but could be useful for
> > future users of it.
> Hi Marius,
> I was just checking up on this patch which is still in the review
> queue here:
> http://bundlebuggy.aaronbentley.com/request/%3C418c22640705012222h5a72f900j4d0d7ae2c655a186@mail.gmail.com%3E
> It's marked as unmerged, but it does look like deleting an empty
> directory does now work.  Maybe I'm missing some subtlety of the error
> this handles.  Do you know if this still wants to be merged?
> --
> Martin

Because I don't trust Version Control Systems with less than 6350 unit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20070723/5f3baa5e/attachment.htm 

More information about the bazaar mailing list