[RFC] add._prepare_file_list -> Command._prepare_file_list?

[Vincent Ladeuil]

>>>>> "robert" == Robert Collins <robertc at robertcollins.net> writes:

    robert> On Mon, 2007-07-02 at 16:35 +1000, Martin Pool wrote:
    >> On 7/2/07, Alexander Belchenko <bialix at ukr.net> wrote:
    >> >
    >> > Robert Collins пишет:
    >> > > Seems to me that _prepare_file_list is a OS specific UI level
    >> > > preprocessing task, so putting it in Command as _prepare_file_list would
    >> > > be reasonable?
    >> >
    >> > Using this method for 'bzr ignore' is very BAD idea, because in this case on win32
    >> > you cannot specify that you need ignore pattern like '*.obj' without auto-globbing.

    robert> Agreed.

    >> I think for now Robert is only going to call that from particular commands.

    robert> Right. I don't want to make *all* paths magically go through it; but we
    robert> take paths in lots of places:
    robert> add
    robert> status
    robert> diff
    robert> commit
    robert> merge
    robert> ignore

    robert> and it seems to me that this logic is applicable to most of those.

Don't forget https://bugs.launchpad.net/bzr/+bug/32669, that
method looks like a very good place to handle the symlinks (the
bug is caused by bzr dereferencing a symlink when it shouldn't).

    Vincent