[RFC] add._prepare_file_list -> Command._prepare_file_list?
Robert Collins
robertc at robertcollins.net
Mon Jul 2 07:53:17 BST 2007
On Mon, 2007-07-02 at 16:35 +1000, Martin Pool wrote:
> On 7/2/07, Alexander Belchenko <bialix at ukr.net> wrote:
> >
> > Robert Collins пишет:
> > > Seems to me that _prepare_file_list is a OS specific UI level
> > > preprocessing task, so putting it in Command as _prepare_file_list would
> > > be reasonable?
> >
> > Using this method for 'bzr ignore' is very BAD idea, because in this case on win32
> > you cannot specify that you need ignore pattern like '*.obj' without auto-globbing.
Agreed.
> I think for now Robert is only going to call that from particular commands.
Right. I don't want to make *all* paths magically go through it; but we
take paths in lots of places:
add
status
diff
commit
merge
ignore
and it seems to me that this logic is applicable to most of those.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070702/11d798bc/attachment.pgp
More information about the bazaar
mailing list