[RFC] add._prepare_file_list -> Command._prepare_file_list?

Alexander Belchenko bialix at ukr.net
Mon Jul 2 07:58:50 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool пишет:
> On 7/2/07, Alexander Belchenko <bialix at ukr.net> wrote:
>>
>> Robert Collins пишет:
>> > Seems to me that _prepare_file_list is a OS specific UI level
>> > preprocessing task, so putting it in Command as _prepare_file_list
>> would
>> > be reasonable?
>>
>> Using this method for 'bzr ignore' is very BAD idea, because in this
>> case on win32
>> you cannot specify that you need ignore pattern like '*.obj' without
>> auto-globbing.
> 
> I think for now Robert is only going to call that from particular commands.
> 
> For the future we have two options:
> 
> 1- say that particular parameters should be glob-expanded on windows
> 2- expand everything, but let them be quoted with backslashes or
> similar.  This is probably not so good because I think the Windows
> shell removes "" before running the program?

Yes, quotes is removed, so bazaar never see it. Otherwise it will be real pain to use in some
situations, like

bzr ci -m "blah blah blah"

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGiKHlzYr338mxwCURAv9+AJ0ZDu/8o9QKI9/qQoIqDKwtZNeuagCeNUEO
RJMtWdrCe59OHMAsO1g2FnM=
=GL0d
-----END PGP SIGNATURE-----



More information about the bazaar mailing list