[RFC] Add api changes..

[Martin Pool]

On 7/2/07, Robert Collins <robertc at robertcollins.net> wrote:
> Looking at add, I'd like to propose:
>
> - move _smart_add_tree to Tree.smart_add
> (Not because we expect many trees to do different things but because its
> pretty clear looking at it that it really is a facet of MutableTree.

To MutableTree then?

>
> - Move _prepare_file_list calls to the UI layer.

Onto Command, maybe?

> - Use _add within Tree.smart_add rather than inventory indirection.
>
> - Preprocess the paths supplied by the user grabbing their dirnames,
> shove them into a set and ensure they are all versioned first, This
> removes the need to check on each individual path and I think will be a
> win.
>
> I think this will get us to where we wanted add to be in terms of API
> cleanliness.

That sounds good to me.

-- 
Martin