[RFC] Add api changes..

Robert Collins robertc at robertcollins.net
Mon Jul 2 05:53:56 BST 2007


On Mon, 2007-07-02 at 13:58 +1000, Martin Pool wrote:
> On 7/2/07, Robert Collins <robertc at robertcollins.net> wrote:
> > Looking at add, I'd like to propose:
> >
> > - move _smart_add_tree to Tree.smart_add
> > (Not because we expect many trees to do different things but because its
> > pretty clear looking at it that it really is a facet of MutableTree.
> 
> To MutableTree then?

Yes.

> >
> > - Move _prepare_file_list calls to the UI layer.
> 
> Onto Command, maybe?

I proposed moving the function to Command in an earlier mail, here I am
proposing the _prepare_file_list call sites move to the run() method of
Command.


-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070702/3c34ef5b/attachment.pgp 


More information about the bazaar mailing list