Sending commit emails from a central location

[Robert Collins]

On Fri, 2007-06-22 at 03:48 +0100, Adeodato Simó wrote:
> * Robert Collins [Fri, 22 Jun 2007 11:17:46 +1000]:
> 
> > Firstly, you can reuse bzr-email/emailer.py:
> > ====
> > from bzrlib.plugins.email import emailer
> > ====
> 
> > No need to copy code at all.
> 
> Well, I thought about that, and while I didn't actually tried to do it,
> the impression I got while considering the possiblity is that I would've
> had to do a fair amount of playing with the class to get the result I
> wanted.

Thats a shame, I'd be happy to accept patches to reduce this need.

> Plus I didn't want to have the need to install bzr-email separately.

Given you're installing it in a single location, I don't see that thats
a big hurdle - but up to you. (Myself, I try to err on the side of less
code to support :)).

> > Secondly, if you configure branch.conf to send email, the email plugin
> > should send it correctly even if you are committing over sftp to a
> > central branch.
> 
> Do you mean that if the remote branch has post_commit_address in its
> branch.conf, pushing to it sends an email iff bzr-email is installed?
> Good to know, but still happy with the functionality provided by
> bzr-hookless-email. ;-)

Thats cool - I wasn't meaning to suggest you wouldn't be happy :). Did
you know about the foreach plugin which is somewhat related ?

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070626/93204f2b/attachment.pgp