Core Developer Handbook draft

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Mon, 2007-06-18 at 16:51 +1000, Martin Pool wrote:
>> post_commit = bzrlib.plugins.email.post_commit
> 
> The preceeding line is not needed; its from the pre-0.15 plugin
> interface. 
> 
>> post_commit_to = bazaar-commits at lists.canonical.com
>> post_commit_mailer = smtplib
> 
> I don't know about the last line being needed either - I certainly don't
> have it in my config.

The default (because you wrote it) is to use a 'mail' program that is found in
your PATH.

On Windows, it doesn't exist, and on my Linux box, it didn't know how to send
anything outside of the local machine.

So I wrote the ability to send using smtplib, which also enables sending
diff/patch as an attachment, rather than inline. Which also helps because the
message is technically Unicode, while the diff hunks are 8-bit strings.

So no, it isn't strictly necessary, but it may be recommended.

It also means that the settings "smtp_server=XXX" and smtp_user and
smtp_password are available.

> 
>> Those lines are a good idea but they're not really related to pqm;
>> that's to let other people see your work in progress by sending mail
>> to a list.  It's nice but totally optional (if you feel shy about
>> intermediate commits.) 
> 
> So lets make it clear they are optional; I think they are a great
> idea :).
> 
> -Rob

I agree, it is quite nice to see what others are up to. If only to feel like
stuff is going on outside. :)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGd0ErJdeBCYSNAAMRAjcIAJ4+MyV+8Ah9jr6sy81gl8VeJUabuwCg1Tto
Lc6QFajj/zdkwuf/xpR5o2Q=
=g+qa
-----END PGP SIGNATURE-----