crash while running register-branch

[Bjorn Tillenius]

On Tue, Jan 09, 2007 at 11:52:06AM +1100, Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> [...]
> > 
> > The error I'm reading is basically the XML RPC interface dumping the raw
> > database exception over the wire, and then our side just dumping that
> > same error to the user. Which is nice for developers, since you can
> > figure out exactly what is going on, but looks pretty bad for users.
> > 
> > I wonder if we just want to wrap xmlrpclib.Fault for all of the
> > 'register-branch' code, and report the full traceback into ~/.bzr.log,
> > and print only a single-line error to the user.
> 
> Probably the best fix is server-side.  Returning an error with details
> that only make sense to developers of the server is of no use to
> clients (and thus no use to users of those clients).  Launchpad ought
> to be able to return an xmlrpclib.Fault with a sensible error message
> in that case, rather than a raw stringified IntegrityError.

The server usually tries to return a sensible xmlrpclib.Fault. If the
server returns a Fault with the error code -1, like in this case, I'd
say it's always a bug in the server. The bzr register-branch plugin
might want to catch such Faults and inform the user about this.

Regards,

Bjorn