[MERGE] alias to respect spaces in quoted arguments (version 3)

Marius Kruger amanic at gmail.com
Thu Nov 30 04:54:38 GMT 2006

hi John,
thanks for the review, I made your changes and attached the updated bundle.

On 11/29/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
> test_commands is the right name, though I'm not sure if it is critical
> enough that we have to do it. But since it is done ...
:) rather fix it sooner than later

You have:
> import errno
> +from cStringIO import StringIO

But cStringIO comes before errno. (Imports should be in sorted order)
I didn't know

You should have a blank line between the class declaration and the first
> entry, and a space between function arguments:
> +class TestGetAlias(TestCase):
> +    def __get_config(self,config_text):
> should be:
> +class TestGetAlias(TestCase):
> +
> +    def __get_config(self, config_text):

I didn't know

Also, I find __ to be much worse than just using _ to indicate something
> is private.

some python inexperience shining through

+        Used to specify an alternative config to use,
> +        which is especially usefull for testing.
useful only has 1 l
engrish is my second language

the rest seems pretty good.



I code therefore I am.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20061130/638b603e/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: alias_quotes.patch
Type: application/octet-stream
Size: 22629 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061130/638b603e/attachment.obj 

More information about the bazaar mailing list