hi John,<br>thanks for the review, I made your changes and attached the updated bundle.<br><br><br><div><span class="gmail_quote">On 11/29/06, <b class="gmail_sendername">John Arbash Meinel</b> <<a href="mailto:john@arbash-meinel.com">
john@arbash-meinel.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">test_commands is the right name, though I'm not sure if it is critical
<br>enough that we have to do it. But since it is done ...<br></blockquote><div>:) rather fix it sooner than later<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
You have:<br><br> import errno<br>+from cStringIO import StringIO</blockquote><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">But cStringIO comes before errno. (Imports should be in sorted order)
<br></blockquote><div>I didn't know <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">You should have a blank line between the class declaration and the first
<br>entry, and a space between function arguments:<br><br>+class TestGetAlias(TestCase):<br>+ def __get_config(self,config_text):<br><br>should be:<br><br>+class TestGetAlias(TestCase):<br>+<br>+ def __get_config(self, config_text):
</blockquote><div>I didn't know </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Also, I find __ to be much worse than just using _ to indicate something
<br>is private.</blockquote><div>some python inexperience shining through <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">+ Used to specify an alternative config to use,
<br>+ which is especially usefull for testing.<br></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">useful only has 1 l<br>
</blockquote><div>engrish is my second language </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">the rest seems pretty good.</blockquote>
</div>gr8<br><br clear="all"><br>-- <br><br><br><br>I code therefore I am.