[step 05] request: 12 steps towards a high performance server

[Andrew Bennetts]

On Wed, Sep 13, 2006 at 11:48:29AM -0500, John Arbash Meinel wrote:
> 
> 
> >    http://people.ubuntu.com/~andrew/bzr/preserve-transport-when-creating-bzrdir/
> >      fix, with test, to ensure make_bzrdir preserves the transport
> 
> The first part of this was already semi-submitted by Robert, and the
> same comment applies here. It would be better to just do:
> 
> segments = mabye_a_url.rsplit('/', 1)
> if len(segments) > 1 and segments[-1] not in ('', '.'):
> 
> At least you aren't still doing '/'.join()
> 
> I thought I had more to say about his old patch....

I've made that change, it seems reasonable to avoid doing more splitting work
that necessary here given how similar the code is either way.

>           _
> Anyway +0.9
> 
> 
> John
> =:->
> 
> PS> Hopefully the joke comes across okay.

Yes, the joke made the journey into my mail reader just fine :)

-Andrew.