[step 05] request: 12 steps towards a high performance server

John Arbash Meinel john at arbash-meinel.com
Wed Sep 13 17:48:29 BST 2006



>    http://people.ubuntu.com/~andrew/bzr/preserve-transport-when-creating-bzrdir/
>      fix, with test, to ensure make_bzrdir preserves the transport

The first part of this was already semi-submitted by Robert, and the
same comment applies here. It would be better to just do:

segments = mabye_a_url.rsplit('/', 1)
if len(segments) > 1 and segments[-1] not in ('', '.'):

At least you aren't still doing '/'.join()

I thought I had more to say about his old patch....

          _
Anyway +0.9


John
=:->

PS> Hopefully the joke comes across okay.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060913/eebcf39d/attachment.pgp 


More information about the bazaar mailing list