[step 03] request: 12 steps towards a high performance server

Andrew Bennetts andrew at canonical.com
Thu Sep 14 06:35:51 BST 2006

On Wed, Sep 13, 2006 at 11:36:28AM -0500, John Arbash Meinel wrote:
> >    http://people.ubuntu.com/~andrew/bzr/open_from_transport/
> >      add an open_from_transport method to bzrdir.py
> Calling the parameter 'transport' is okay. I've tried to avoid using
> variable names that match module names, just because we are tending
> towards doing:
> from bzrlib import (
>   mod1,
>   mod2,
>   ...
>   )
> (This helps a lot on my lazy_import branch)

Yeah.  'transport' is still better than 't', though, despite the shadowing of a
global.  Perhaps 'a_transport'?  I find that a little bit ugly, but perhaps it's
a lesser evil.

> And there really should be an explicit test for
> 'BzrDir.open_from_transport()'.
> I like the refactoring, but only +0.5 until there is a test. (Which may
> exist in a later diff, I haven't got through them all yet.)

No explicit test later that I can see.  I blame Martin, he wrote this bit ;)

I've added three test methods for open_from_transport.


More information about the bazaar mailing list