[step 03] request: 12 steps towards a high performance server

John Arbash Meinel john at arbash-meinel.com
Wed Sep 13 17:36:28 BST 2006


>    http://people.ubuntu.com/~andrew/bzr/open_from_transport/
>      add an open_from_transport method to bzrdir.py


Calling the parameter 'transport' is okay. I've tried to avoid using
variable names that match module names, just because we are tending
towards doing:

from bzrlib import (
  mod1,
  mod2,
  ...
  )

(This helps a lot on my lazy_import branch)

And there really should be an explicit test for
'BzrDir.open_from_transport()'.

I like the refactoring, but only +0.5 until there is a test. (Which may
exist in a later diff, I haven't got through them all yet.)

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060913/ab0b6fa1/attachment.pgp 


More information about the bazaar mailing list