[Bug] 'bzr add --dry-run' actually added files

[Michael Ellerman]

On Wed, 2006-08-16 at 23:09 -0500, John Arbash Meinel wrote:
> Michael Ellerman wrote:
> > On 8/17/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
> >> Alexander Belchenko wrote:
> >> > Martin Pool пишет:
> >>
> >> ...
> >>
> >> >>> When smart_add_tree invoked argument save is omitted therefore
> >> >>> '--dry-run' never works. Attached obvious fix for this problem.
> > 
> > So why is bzrlib/tests/test_smart_add.py:TestSmartAdd.test_add_dry_run()
> > not catching this?
> > 
> > cheers
> 
> Because at present, a working tree has to reload it's working inventory
> after the disk representation has changed.
> 
> Robert and I have discussed it a bit, and we decided that it would be
> better if the working inventory was only cached for the period of a read
> or write lock. Which would fix these sort of issues.

Ok, and that's changed since I initially wrote it? I just thought I was
going crazy .. again.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060817/bbe5c5fd/attachment.pgp