[Bug] 'bzr add --dry-run' actually added files

[John Arbash Meinel]

Michael Ellerman wrote:
> On 8/17/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
>> Alexander Belchenko wrote:
>> > Martin Pool пишет:
>>
>> ...
>>
>> >>> When smart_add_tree invoked argument save is omitted therefore
>> >>> '--dry-run' never works. Attached obvious fix for this problem.
> 
> So why is bzrlib/tests/test_smart_add.py:TestSmartAdd.test_add_dry_run()
> not catching this?
> 
> cheers

Because at present, a working tree has to reload it's working inventory
after the disk representation has changed.

Robert and I have discussed it a bit, and we decided that it would be
better if the working inventory was only cached for the period of a read
or write lock. Which would fix these sort of issues.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060816/df876217/attachment.pgp