[PATCH] Fix installation of tests.intertree_implementations

Robert Collins robertc at robertcollins.net
Tue Aug 1 04:44:22 BST 2006


On Mon, 2006-07-31 at 08:33 -0500, John Arbash Meinel wrote:
> Robert Collins wrote:
> > On Sun, 2006-07-30 at 08:51 -0500, John Arbash Meinel wrote:
> >> Jelmer Vernooij wrote:
> >>> Hi,
> >>>
> >>> Attached patch fixes setup.py to install
> >>> bzrlib.tests.{inter,}tree_implementations.
> >>>
> >>> Cheers,
> >>>
> >>> Jelmer 
> >>>
> >> +1. So Robert, I guess you did introduce a (small) regression. :)
> > 
> > It would be nice to test that this does not occur. Perhaps:
> >  - do an install
> >  - run bzr selftest '^.$' on the installed copy. If it errors, something
> > it tried to load was missing.
> > 
> > Rob
> 
> That is part of the steps for creating a bzr release.
> 
> So it would be caught there.

It would be nice to catch it earlier. Running no tests should be a
relatively fast test to run. And it avoids the question of packaging the
wrong things as you mention.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060801/50c52541/attachment.pgp 


More information about the bazaar mailing list