[PATCH] Fix installation of tests.intertree_implementations

John Arbash Meinel john at arbash-meinel.com
Mon Jul 31 14:33:05 BST 2006

Robert Collins wrote:
> On Sun, 2006-07-30 at 08:51 -0500, John Arbash Meinel wrote:
>> Jelmer Vernooij wrote:
>>> Hi,
>>> Attached patch fixes setup.py to install
>>> bzrlib.tests.{inter,}tree_implementations.
>>> Cheers,
>>> Jelmer 
>> +1. So Robert, I guess you did introduce a (small) regression. :)
> It would be nice to test that this does not occur. Perhaps:
>  - do an install
>  - run bzr selftest '^.$' on the installed copy. If it errors, something
> it tried to load was missing.
> Rob

That is part of the steps for creating a bzr release.

So it would be caught there.

Or it would be caught by someone using a packaged version.

But I agree with Martin, it would be reasonable to fix it.

What is wrong with doing something like:

for root, dirs, files in os.walk('bzrlib'):
  if '__init__.py' in files:
    modules.append(root.replace('/','.').replace('\\', '.'))

That seems like it would find all the bzrlib modules. Though it might
find something like 'urlgrabber' which we don't really need to bundle.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060731/9ff80aa8/attachment.pgp 

More information about the bazaar mailing list