[MERGE] bundle commandline cleanup

Aaron Bentley aaron.bentley at utoronto.ca
Thu Jun 29 16:36:13 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
>>>^- So why are you always pulling from 'last_revision()' rather than the
>>>base revision that was specified? Potentially they are not even the same
>>>ancestry.

Okay, I've had a closer look at the code.  The scenario you describe
can't happen, because the purpose of that codepath is to determine the
base revision when the user hasn't specified one.  If the user has
specified a base, we won't hit that codepath.

In pseudocode:

if no_base_specified:
    base_revision = common_ancestor(base_branch.last_revision(),
                                    target_revision)

So I don't think that needs fixing.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEo/Nt0F+nu1YWqI0RAvAsAJ9pfQo77HvWyLIGAC43RxwqNEcK/gCeOPyp
CL28qeWzq7fLzSvj/RRmbWU=
=9MUK
-----END PGP SIGNATURE-----




More information about the bazaar mailing list